Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializer option #9

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Add serializer option #9

merged 8 commits into from
Sep 11, 2023

Conversation

AkifumiSato
Copy link
Collaborator

@AkifumiSato AkifumiSato commented Sep 10, 2023 •
edited
Loading

  • StoreNameに任意の型を指定可能に修正
  • transitオプションでSessionStorageやURLに保存・読み込みする時に任意のSerialize/Desirialzeを指定可能に修正

@koichik

This comment was marked as resolved.

Sign in to view
@AkifumiSato AkifumiSato changed the title Add transit option, fix StoreName type Add serializer Sep 10, 2023
@AkifumiSato AkifumiSato changed the title Add serializer Add serializer option Sep 10, 2023
@AkifumiSato
Copy link
Collaborator Author

AkifumiSato commented Sep 10, 2023 •
edited
Loading

SroreNameの方の修正は戻しましてPR名も修正しました。

koichik
koichik reviewed Sep 10, 2023
View reviewed changes
Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

乙でした！ ちょっと細かいコメントをいくつか

packages/location-state-core/src/stores/storage-store.ts Outdated Show resolved Hide resolved
packages/location-state-core/src/stores/storage-store.ts Show resolved Hide resolved
packages/location-state-core/src/stores/url-store.ts Outdated Show resolved Hide resolved
packages/location-state-core/src/stores/url-store.ts Outdated Show resolved Hide resolved
packages/location-state-core/src/stores/url-store.ts Show resolved Hide resolved
packages/location-state-core/src/stores/types.ts Show resolved Hide resolved
koichik
koichik approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接このプルリクと関係ないコメントをしちゃいましたがLGTMです！乙でした！

packages/location-state-core/src/stores/url-store.ts Show resolved Hide resolved
@AkifumiSato AkifumiSato merged commit 766479c into main Sep 11, 2023
1 check passed
@AkifumiSato AkifumiSato deleted the custom-option branch September 11, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koichik koichik koichik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkifumiSato @koichik